Skip to content

Correct the spelling of CocoaPods in README #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ReadmeCritic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct the spelling of CocoaPods in README #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ The test code requires Quick and Nimble to be implemented. You can do so by runn

## Installation

### Cocoapods
### CocoaPods
DateInRegion is available through [CocoaPods](http://cocoapods.org). To install
it, simply add the following line to your Podfile:

Expand All @@ -216,7 +216,7 @@ I have taken the following decisions when setting up the library. I welcome fee
Decision | Rationale
------------- | -------------
Primary function of `DateInRegion` is to be able to switch and convert dates between regions. Not to deal with dates in the local region, although it can be used for that.|That is just the way I needed it :-)
`DateInRegion` is not an extension to `NSDate` | `NSDate` extensions in general represent the current date in various formats. Extensions also limit the class as you cannot add stored properties. The latter I need to store the regional data (calendar, time zone & locale). Cocoapods offers plenty `NSDate` extensions e.g. [SwiftDate](www.cocoapods.com/pods/SwiftDate).
`DateInRegion` is not an extension to `NSDate` | `NSDate` extensions in general represent the current date in various formats. Extensions also limit the class as you cannot add stored properties. The latter I need to store the regional data (calendar, time zone & locale). CocoaPods offers plenty `NSDate` extensions e.g. [SwiftDate](www.cocoapods.com/pods/SwiftDate).
Do not include an initialiser from string | That is too complicated with all the different ways of notation in the world. It would have too little benefit next to the currently available convenience intialisers instead.
Do not attempt to mimic all properties and functions of the NSDateFormatter, NSDateComponents etc. E.g. NSDateFormatter's ``localizedStringFromDate`` or ``weekdaySymbols`` | Sometimes it is just easier to use the ``date`` property from ``DateInRegion`` instead.
Equation ``==`` is not for just the date value but for the whole object | Alike NSObject regulations; although objects do not have to be the same instance, they must contain equal properties
Expand Down