Open
Conversation
TimothyWillard
added
bug
pearsonca
approved these changes
Aug 5, 2025
Contributor
pearsonca
left a comment
pearsonca
left a comment
There was a problem hiding this comment.
This seems generally fine. We might want to shift the R-specific items into .gitignore files in the R packages - could be in this or deferred to later spin off of the R elements into their own repos.
Contributor
There was a problem hiding this comment.
should the R elements be put into .gitignore files within the packages?
Contributor
Author
There was a problem hiding this comment.
We can do that, it'll just be duplicated 3 times so it might be better to delay until spin off?
TimothyWillard
force-pushed
the
clean-gitignore
branch
from
2c43ebc to
d9552ab
Compare
Made use of off the shelf `.gitignore` files provided by https://github.com/github/gitignore for R, python and OS ignores. Then consolidated down the `flepiMoP` specific ignores with comments.
TimothyWillard
force-pushed
the
clean-gitignore
branch
from
d9552ab to
4d29e3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes.
Made use of off the shelf
.gitignorefiles provided by https://github.com/github/gitignore for R, python and OS ignores. Then consolidated down theflepiMoPspecific ignores with comments.Does this pull request make any user interface changes? If so please describe.
The user interface changes are none.
No documentation updates were required.
What does your pull request address? Tag relevant issues.
This pull request addresses #540.