Skip to content

mftrace 1.2.20#57566

Closed
SeekingMeaning wants to merge 1 commit intoHomebrew:masterfrom
SeekingMeaning:mftrace-1.2.20
Closed

mftrace 1.2.20#57566
SeekingMeaning wants to merge 1 commit intoHomebrew:masterfrom
SeekingMeaning:mftrace-1.2.20

Conversation

@SeekingMeaning
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Previous attempt: #48931

Upstream fix: hanwen/mftrace#14

chenrui333
chenrui333 previously approved these changes Jul 7, 2020
Copy link
Copy Markdown
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chenrui333 chenrui333 dismissed their stale review July 7, 2020 00:35

mirror missing

@SeekingMeaning SeekingMeaning force-pushed the mftrace-1.2.20 branch 3 times, most recently from 4412f69 to 3cf450c Compare July 7, 2020 01:03
chenrui333
chenrui333 previously approved these changes Jul 7, 2020
@chenrui333
Copy link
Copy Markdown
Member

FYI, currently the CI has some issue, we are aware of this.

@SeekingMeaning
Copy link
Copy Markdown
Contributor Author

SeekingMeaning commented Jul 7, 2020

(Should I re-trigger CI with rebase when this happens or leave it as is?)

@chenrui333
Copy link
Copy Markdown
Member

I just triggered a new build, 🤞

@chenrui333
Copy link
Copy Markdown
Member

mojave check failed. will check on this CI build tomorrow.

Copy link
Copy Markdown
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@BrewTestBot
Copy link
Copy Markdown
Contributor

🤖 A scheduled task has triggered a merge.

@SeekingMeaning SeekingMeaning deleted the mftrace-1.2.20 branch July 8, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants