Created separate column for init values (1 or more) and current value (singular value, old 'init_value') #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardwu
commented
Nov 21, 2018
richardwu
force-pushed
the
multiple_init_values
branch
from
1ef2361 to
f08b01f
Compare
richardwu
force-pushed
the
multiple_init_values
branch
from
f08b01f to
f5a6ea0
Compare
Collaborator
Author
|
Closing this to combine with #32. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to specify multiple initial values for a given cell that we could use in a special
MultiInitFeaturizerorMultiOccurFeaturizer.The old
init_valueis nowcurrent_value(all featurizers have been changed to referencecurrent_valueand renamed from e.g.InitFeaturizertoCurrentFeaturizer).Also fixed a bug in
InitSimFeaturizerwhere it wasn't computing the similarity metrics correctly between theinit_valueand values in the domain.