fractional theorem numbers; see #601 #613
Conversation
There was a problem hiding this comment.
Should there be a space between } and and?
There was a problem hiding this comment.
Unfortunately, the script that makes version.tex includes a linebreak in the definition of \OPTversion. So putting a space here resulted in a double-width space in the output.
There was a problem hiding this comment.
Well, how about if we fix the script instead?
There was a problem hiding this comment.
Feel free; that's your bailiwick.
There was a problem hiding this comment.
If you want to fix the script, here is one possibility (I haven't actually tested it, but I'm pretty sure it'll work):
version.tex:
/bin/echo -n '\newcommand{\OPTversion}{' > version.tex
/bin/echo -n "$$(git describe --always --long)" >> version.tex
/bin/echo -n '}' >> version.tex
| \@xtwo=#2 | ||
| \multiply\@xtwo by \value{@newthmnum} | ||
| \multiply\@xone by \value{@newthmdenom} | ||
| \ifnum\@xone>\@xtwo\else\errmessage{Theorem numbers out of order}\fi |
There was a problem hiding this comment.
I don't know if you ever plan on merging this, but if you do, it might be nice to give expect errors like
| \ifnum\@xone>\@xtwo\else\errmessage{Theorem numbers out of order}\fi | |
| \ifnum\@xone>\@xtwo\else\errmessage{Theorem numbers out of order: #1/#2 <= \arabic{@newthmnum} / \arabic{@newthmdenom}}\fi |
(Or maybe we want \the\value instead of \arabic?)
3 participants
No description provided.