Skip to content

Conversation

@Hmbown
Copy link
Owner

@Hmbown Hmbown commented Jan 20, 2026

Summary:\n- Resolve ALEPH_WORKSPACE_ROOT with PWD/INIT_CWD and expand ~.\n- Keep repo-root snapping while honoring env precedence.\n- Add tests for relative and tilde overrides.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Hmbown, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refines how the aleph system determines its workspace root, offering both greater control and improved reliability. By introducing an explicit environment variable (ALEPH_WORKSPACE_ROOT) and enhancing the automatic detection process to consider common invocation directories (PWD, INIT_CWD), it aims to resolve ambiguities and prevent path-related errors, ultimately providing a more stable and predictable environment for users.

Highlights

  • Explicit Workspace Override: Introduced the ALEPH_WORKSPACE_ROOT environment variable, allowing users to explicitly define the workspace root. This variable supports relative paths and tilde expansion for greater flexibility.
  • Enhanced Auto-Detection Logic: Improved the automatic workspace root detection mechanism to prioritize PWD and INIT_CWD environment variables before falling back to os.getcwd(). This ensures more accurate detection across various execution contexts.
  • Path Resolution Fixes: Addressed issues where paths could 'escape' the workspace root, particularly when the server is initiated from an install path, by implementing robust resolution for environment-provided paths.
  • Comprehensive Testing: Added new unit tests to validate the improved workspace root detection logic, covering scenarios such as relative path overrides via PWD/INIT_CWD and tilde expansion in ALEPH_WORKSPACE_ROOT.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Hmbown Hmbown merged commit 5da61c0 into main Jan 20, 2026
4 checks passed
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces significant improvements to workspace root detection by incorporating ALEPH_WORKSPACE_ROOT, PWD, and INIT_CWD environment variables, along with tilde expansion. This enhances flexibility and robustness in how the workspace root is determined. The changes are well-documented in CHANGELOG.md, MCP_SETUP.md, README.md, and docs/CONFIGURATION.md, and new tests have been added to cover the updated logic. The implementation is clean and correctly handles various scenarios for path resolution. I did not identify any issues that meet the criteria for medium, high, or critical severity.

@Hmbown Hmbown deleted the Hmbown/test-mcps-skills branch January 21, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants