🧹 Extract getRateLimitReset helper function in github.ts#67
🧹 Extract getRateLimitReset helper function in github.ts#67
Conversation
Extract duplicated rate limit reset timestamp calculation into a single helper function. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively refactors duplicated code into a new helper function getRateLimitReset, which improves maintainability. However, I've found a critical issue in the new function's implementation where it doesn't handle non-numeric values in the X-RateLimit-Reset header. This could lead to an unhandled exception and crash the application. Please see my comment for a suggested fix.
|
|
||
| function getRateLimitReset(res: Response): number { | ||
| const resetHeader = res.headers.get("X-RateLimit-Reset"); | ||
| return resetHeader ? parseInt(resetHeader, 10) : Math.floor(Date.now() / 1000) + 3600; |
There was a problem hiding this comment.
The current implementation can lead to an unhandled exception. If the X-RateLimit-Reset header is present but contains a non-numeric string (e.g., an empty string or malformed value), parseInt will return NaN. This NaN value is then passed to the RateLimitError constructor, which will create an Invalid Date. Calling .toISOString() on an invalid date throws a RangeError, which will crash the application. It's crucial to handle this case by validating the result of parseInt.
const resetTimestamp = parseInt(resetHeader || "", 10);
return !Number.isNaN(resetTimestamp) ? resetTimestamp : Math.floor(Date.now() / 1000) + 3600;
# Conflicts: # src/lib/github.ts
|
This PR is being closed as superseded by #66. The github.ts changes were consolidated there, including the conflict resolution needed to keep the related improvements together. |
1 participant
🎯 What: The duplicated rate limit reset timestamp calculation in
src/lib/github.tswas extracted into a reusable helper functiongetRateLimitReset.💡 Why: This directly reduces code duplication between the
handleResponseandgraphqlfunctions, improving both maintainability and readability.✅ Verification: The full test suite was executed (
npm run test -- --run) and no regressions were detected. The project successfully builds.✨ Result: A safer, cleaner, and centralized way to retrieve the correct rate limit reset timestamp across both REST and GraphQL handlers.
PR created automatically by Jules for task 5603259945699259929 started by @is0692vs