Skip to content

📦 [Consolidated] PR #59, #67 の github.ts 改善統合・レビュー指摘対応 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
is0692vs merged 8 commits into from
Mar 14, 2026
Merged

📦 [Consolidated] PR #59, #67 の github.ts 改善統合・レビュー指摘対応 #66

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e7db987
🧹 [Code Health] Refactor graphql utility to use handleResponse
google-labs-jules[bot] Mar 13, 2026
8686060
⚡ Optimize GitHub events fetching by parallelizing requests
google-labs-jules[bot] Mar 13, 2026
8d77b62
refactor: extract getRateLimitReset helper function
google-labs-jules[bot] Mar 13, 2026
d7d47be
Merge origin/main into consolidated github.ts PR
is0692vs Mar 14, 2026
b95c8e2
Merge PR #59 into consolidated github.ts PR
is0692vs Mar 14, 2026
e1fc9e8
Merge PR #67 into consolidated github.ts PR
is0692vs Mar 14, 2026
b3a57d1
⚡ Optimize GitHub events fetching by parallelizing requests and log s…
google-labs-jules[bot] Mar 14, 2026
f83a79b
Merge branch 'main' into perf-optimize-fetch-activity-246903503792235…
is0692vs Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/lib/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,12 +630,19 @@ export async function fetchActivity(
const pages = [1, 2, 3];
const allEvents: GitHubEvent[] = [];

for (const page of pages) {
const promises = pages.map((page) =>
restGet<GitHubEvent[]>(
`/users/${encodeURIComponent(username)}/events/public?per_page=100&page=${page}`,
token
)
);

// Suppress unhandled promise rejections for subsequent pages if we break early or throw
promises.forEach((p) => p.catch((e) => console.error("Suppressed event fetch error:", e)));
Comment on lines +640 to +641
Copy link

@coderabbitai coderabbitai bot Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

forEach コールバックから値を返しているため、リンターエラーが発生しています。

p.catch() は Promise を返しますが、forEach はコールバックの戻り値を無視します。Biome がこれを疑わしいパターンとしてフラグしています。void 演算子を使用して意図を明確にするか、for-of ループに変更することで解決できます。

♻️ 修正案

オプション 1: void 演算子を使用

-  promises.forEach((p) => p.catch((e) => console.error("Suppressed event fetch error:", e)));
+  promises.forEach((p) => void p.catch((e) => console.error("Suppressed event fetch error:", e)));

オプション 2: for-of ループを使用

-  promises.forEach((p) => p.catch((e) => console.error("Suppressed event fetch error:", e)));
+  for (const p of promises) {
+    p.catch((e) => console.error("Suppressed event fetch error:", e));
+  }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// Suppress unhandled promise rejections for subsequent pages if we break early or throw
promises.forEach((p) => p.catch((e) => console.error("Suppressed event fetch error:", e)));
// Suppress unhandled promise rejections for subsequent pages if we break early or throw
promises.forEach((p) => void p.catch((e) => console.error("Suppressed event fetch error:", e)));
🧰 Tools
🪛 Biome (2.4.6)

[error] 641-641: This callback passed to forEach() iterable method should not return a value.

(lint/suspicious/useIterableCallbackReturn)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/lib/github.ts` around lines 640 - 641, The linter flags the
promises.forEach callback because p.catch(...) returns a Promise which forEach
ignores; fix by explicitly signaling intent or iterating properly: either prefix
the callback call with the void operator (change the callback passed to
promises.forEach in the code that currently references promises.forEach((p) =>
p.catch(...)) to use void p.catch(...)) or replace the forEach with an explicit
for-of loop over the promises array and call p.catch(...) inside it; update the
occurrence that uses promises.forEach in this file (the suppressed event fetch
error line) accordingly.


for (const p of promises) {
try {
const events = await restGet<GitHubEvent[]>(
`/users/${encodeURIComponent(username)}/events/public?per_page=100&page=${page}`,
token
);
const events = await p;
allEvents.push(...events);
if (events.length < 100) break;
} catch (error) {
Expand Down
Loading