-
Notifications
You must be signed in to change notification settings - Fork 0
π§ͺ [Test] Add unit tests for fetchViewerLogin #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import { describe, it, expect, vi, beforeEach, afterEach } from "vitest"; | ||
| import { fetchViewerLogin } from "../githubViewer"; | ||
| import { GitHubApiError } from "../types"; | ||
|
|
||
| const mockFetch = vi.fn(); | ||
|
|
||
| describe("fetchViewerLogin", () => { | ||
| beforeEach(() => { | ||
| vi.stubGlobal("fetch", mockFetch); | ||
| mockFetch.mockReset(); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| vi.unstubAllGlobals(); | ||
| }); | ||
|
|
||
| it("should return login on successful fetch", async () => { | ||
| mockFetch.mockResolvedValue({ | ||
| ok: true, | ||
| json: async () => ({ login: "testuser" }), | ||
| }); | ||
|
|
||
| const login = await fetchViewerLogin("test-token"); | ||
| expect(login).toBe("testuser"); | ||
|
|
||
| expect(mockFetch).toHaveBeenCalledTimes(1); | ||
| expect(mockFetch).toHaveBeenCalledWith("https://api.github.com/user", { | ||
| headers: { | ||
| Accept: "application/vnd.github+json", | ||
| Authorization: "Bearer test-token", | ||
| "User-Agent": "github-user-summary", | ||
| }, | ||
| cache: "no-store", | ||
| }); | ||
| }); | ||
|
|
||
| it("should throw GitHubApiError when fetch is not ok", async () => { | ||
| mockFetch.mockResolvedValue({ | ||
| ok: false, | ||
| status: 401, | ||
| json: async () => ({ message: "Bad credentials" }), | ||
| }); | ||
|
|
||
| await expect(fetchViewerLogin("invalid-token")).rejects.toThrow(GitHubApiError); | ||
|
|
||
| // We can also check specific properties on the error | ||
| try { | ||
| await fetchViewerLogin("invalid-token"); | ||
| } catch (e) { | ||
| expect(e).toBeInstanceOf(GitHubApiError); | ||
| expect((e as GitHubApiError).status).toBe(401); | ||
| expect((e as GitHubApiError).message).toBe("Failed to resolve current GitHub user"); | ||
| } | ||
|
|
||
| expect(mockFetch).toHaveBeenCalledTimes(2); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case calls
fetchViewerLogintwice: once withexpect.rejectsand again inside atry...catchblock. This is redundant and leads to the assertion thatmockFetchwas called twice, which is not representative of a single test scenario.A cleaner and more efficient approach is to use a single
try...catchblock to both verify that an error is thrown and inspect its properties. This ensures the function under test is only called once.