Skip to content

test(api): align slug validation messaging #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
is0692vs merged 2 commits into from
Mar 18, 2026
Merged

test(api): align slug validation messaging #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b34c89e
test(api): align slug validation messaging
is0692vs Mar 17, 2026
ee7b03d
Refine slug error for edge hyphen positions
is0692vs Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions apps/api/src/utils/__tests__/validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ describe("validation utils", () => {
});

it("validates length", () => {
expect(validateSlug("ab")).toBe("slug must be 3-40 characters");
expect(validateSlug("a".repeat(41))).toBe("slug must be 3-40 characters");
expect(validateSlug("ab")).toBe("slug must be 3–40 characters");
expect(validateSlug("a".repeat(41))).toBe("slug must be 3–40 characters");
});

it("validates character set", () => {
Expand All @@ -21,6 +21,11 @@ describe("validation utils", () => {
expect(validateSlug("my--slug")).toBe("slug must not contain consecutive hyphens");
});

it("rejects leading/trailing hyphens", () => {
expect(validateSlug("-invalid")).toBe("slug must not start or end with a hyphen");
expect(validateSlug("invalid-")).toBe("slug must not start or end with a hyphen");
});

it("accepts valid slugs", () => {
expect(validateSlug("my-valid-slug-123")).toBeNull();
expect(validateSlug("abc")).toBeNull();
Expand Down
3 changes: 2 additions & 1 deletion apps/api/src/utils/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ export const SLUG_RE = /^[a-z0-9][a-z0-9-]*[a-z0-9]$|^[a-z0-9]$/;
export function validateSlug(slug: unknown): string | null {
if (typeof slug !== "string") return "slug is required";
const s = slug.trim().toLowerCase();
if (s.length < 3 || s.length > 40) return "slug must be 3-40 characters";
if (s.length < 3 || s.length > 40) return "slug must be 3–40 characters";
if (s.startsWith("-") || s.endsWith("-")) return "slug must not start or end with a hyphen";
if (!SLUG_RE.test(s)) return "slug must contain only lowercase letters, numbers, and hyphens";
if (s.includes("--")) return "slug must not contain consecutive hyphens";
return null;
Expand Down
Loading