Update to version 0.12 for supporting ruby 3.3.10#31
Update to version 0.12 for supporting ruby 3.3.10#31dhruvasagar-mb wants to merge 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the gem/tooling to support Ruby 3.3.10 and newer dependency versions (notably json_api_client), along with accompanying CI, Docker, RuboCop, and spec adjustments.
Changes:
- Bump runtime/tooling versions (Ruby 3.3.10, gem version 0.12,
json_api_client ~> 1.23.0, debug/rubocop updates). - Update v2 helper implementations for newer dependencies (e.g., requestor init, retry logic, minor formatting/robustness tweaks).
- Adjust specs and lint config to match new behavior and keep CI stable/fast.
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
spec/spec_helper.rb |
Updates load path and switches debugger; adds stdlib requires used by specs. |
spec/integration/v2/resource_spec.rb |
Minor spec formatting + matcher update for Ruby/RSpec compatibility. |
spec/frederick_api/v2/resource_spec.rb |
Formatting-only changes in specs. |
spec/frederick_api/v2/helpers/retrier_spec.rb |
Stubs sleep to avoid delays from new retry backoff. |
spec/frederick_api/v2/helpers/requestor_spec.rb |
Refactors stubbing style for newer Ruby/RSpec. |
spec/frederick_api/v2/helpers/query_builder_spec.rb |
Consolidates stubs via receive_messages. |
spec/frederick_api/v2/helpers/paginator_spec.rb |
Stubs sleep and refactors stubs to align with retry changes. |
spec/frederick_api/v2/helpers/backgroundable_parser_spec.rb |
Refactors response stubbing style. |
spec/frederick_api/v2/email_document_spec.rb |
Removes stray leading blank line. |
lib/frederick_api/version.rb |
Bumps gem version to 0.12. |
lib/frederick_api/v2/resource.rb |
Refactors token/header helpers to pass blocks through more directly. |
lib/frederick_api/v2/helpers/retrier.rb |
Renames retry arg, narrows rescue, and adds backoff sleep. |
lib/frederick_api/v2/helpers/requestor.rb |
Adds cgi parsing, adjusts regexes, updates initializer for newer json_api_client. |
lib/frederick_api/v2/helpers/query_builder.rb |
Formatting-only alignment changes. |
lib/frederick_api/v2/helpers/paginator.rb |
Regex tweak + narrows rescue type. |
lib/frederick_api/v2/helpers/backgroundable_parser.rb |
Formatting-only (blank line). |
lib/frederick_api/v2/errors/errors.rb |
Adds rubocop suppression and minor formatting in to_s. |
frederick_api.gemspec |
Adds Ruby requirement and bumps json_api_client dependency. |
Gemfile |
Switches debugger gem and unpins rubocop gems. |
Dockerfile |
Updates base image to Ruby 3.3.10. |
.ruby-version |
Updates local Ruby version to 3.3.10. |
.rubocop.yml |
Updates RuboCop config for newer RuboCop + Ruby 3.3.10. |
.github/workflows/ci_steps.yml |
Updates CI Ruby version to 3.3.10. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| rescue StandardError | ||
| attempts += 1 | ||
| attempts <= n ? retry : raise | ||
| sleep(attempts * 5) | ||
| raise unless attempts <= max_attempts | ||
|
|
||
| sleep((attempts - 1) * 5) | ||
| retry |
|
|
||
| def initialize(klass, path = nil) | ||
| @klass = klass | ||
| super(klass) |
There was a problem hiding this comment.
Can you help me understand this change?
There was a problem hiding this comment.
On second thought, I don't see a need to call the parent class for assigning a variable. I think it would be safer to revert.
|
|
||
| def initialize(klass, path = nil) | ||
| @klass = klass | ||
| super(klass) |
There was a problem hiding this comment.
On second thought, I don't see a need to call the parent class for assigning a variable. I think it would be safer to revert.
Summary
Updated dependencies to latest versions
Implementation
N/A
Test Plan
Improved tests to run faster
Security Impact
For assistance, see this wiki page.