feat: rudimentary markers save and load#36
Open
aonmkugs wants to merge 1 commit intoHillobar:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a rudimentary way to save markers per video. When you click on the "Record" button the markers are saved in a JSON file.
If such file exists with the same filename (
<video_name>_markers.json) in the source video folders it will load it when you load/switch to this video and restore the markers.The save/load is really a dumb JSON dumping/loading of the GUI variable
self.markers.This create an artifact .json file each time you record a video (as long as there are markers), it might not be what everyone likes so it could be an option or could be decoupled of the Record button, but for my usage I found it useless to make a new button just for this when most of the time if there are markers I want to save them with the source video if I need to generate the project again in the future.