Skip to content

[F3-2] Update minor issues in admin portal#26

Open
elsiedp wants to merge 9 commits intodevfrom
fix/f3-2-minor-issues-from-multi-pr
Open

[F3-2] Update minor issues in admin portal#26
elsiedp wants to merge 9 commits intodevfrom
fix/f3-2-minor-issues-from-multi-pr

Conversation

@elsiedp
Copy link
Copy Markdown

@elsiedp elsiedp commented Mar 25, 2026

👋 TL;DR

  • Updated user router to allow role changes while preventing profile modifications for users outside the admin's managed home region.
  • Refactored user update logic to streamline authorization checks and ensure existing user data is preserved when unauthorized edits are attempted.
  • Enhanced tests to validate the new behavior, ensuring that profile fields remain unchanged while roles can still be updated.

🔎 Details

(coming soon)

✅ How to Test

(coming soon)

🥜 GIF

lack-of-hustle

@elsiedp elsiedp requested a review from dnishiyama as a code owner March 25, 2026 16:33
@makeplane
Copy link
Copy Markdown

makeplane bot commented Mar 25, 2026

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

elsiedp and others added 7 commits March 26, 2026 00:50
…al URL validation schema in the validators package. (#23)
* Update modals and add mobile filter sheet

- Updated various modal components to improve layout and responsiveness, including adjustments to class names for better styling.
- Introduced a new MobileFilterSheet component for mobile devices to manage filters more effectively.
- Integrated MobileFilterSheet into AOsTable, AreasTable, and other relevant components to enhance user experience on smaller screens.
- Adjusted filter handling logic to accommodate the new mobile filter interface.

* Enhance admin layout with titles and z-index adjustments

- Added a title prop to the Layout component for better page identification across various admin pages.
- Updated the z-index for the header to ensure proper stacking context.
- Adjusted padding for content areas to improve layout consistency.
- Modified several admin pages to utilize the new title feature, enhancing user experience and accessibility.
- Introduced EVENT_CATEGORY_OPTIONS and EVENT_CATEGORY_LABEL_MAP constants for better management of event categories.
- Updated LocationEventForm, AdminEventTypesModal, and AdminWorkoutsModal to utilize the new constants for displaying event category labels.
- Improved label formatting to include category descriptions where applicable.
* Enhance event handling and introduce map event router

- Added support for invalidating map queries in AdminDeleteModal and AdminWorkoutsModal.
- Updated AdminWorkoutsModal to include loading state and improved event creation/updating feedback.
- Refactored event querying to use new map-specific endpoints, enhancing filtering capabilities.
- Introduced a new map event router to handle event-related operations with improved structure and filtering options.

* Updated the event router to include pagination and sorting capabilities for the `all` endpoint.
…modifications for users outside the admin's managed home region.

- Refactored user update logic to streamline authorization checks and ensure existing user data is preserved when unauthorized edits are attempted.
- Enhanced tests to validate the new behavior, ensuring that profile fields remain unchanged while roles can still be updated.
@elsiedp elsiedp force-pushed the fix/f3-2-minor-issues-from-multi-pr branch from 4728c3d to 0e8295a Compare March 25, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant