[Datasets] Task/rdmp 33 dataset update post load

[JFriel]

Proposed Change

Summarise your proposed changes here, including any notes for reviewers.

Type of change

What types of changes does your code introduce? Tick all that apply.

• Bugfix (non-breaking change which fixes an issue)
• New Feature (non-breaking change which adds functionality)
• Breaking Change (fix or feature that would cause existing functionality to not work as expected)
• Documentation-Only Update
• Other (if none of the other choices apply)

Checklist

By opening this PR, I confirm that I have:

• Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
• Created or updated any tests if relevant
• Have validated this change against the Test Plan
• Requested a review by one of the repository maintainers
• Have written new documentation or updated existing documentation to detail any new or updated functionality and how to use it
• Have added an entry into the changelog

To fix the issue, the assignment to founddataset on line 90 should be removed entirely, as it serves no purpose in the method. This will eliminate the "useless assignment" and make the code cleaner and more maintainable. No additional changes are required, as the removal does not affect the logic or functionality of the test.

---

To fix the issue, the assignment to the provider variable on line 1163 should be removed entirely, as it is not used anywhere in the code. This will eliminate the unnecessary assignment and make the code cleaner. No additional changes are required, as the subsequent assignment to providerConfiguration already retrieves the necessary object.

---

To fix the issue, the readonly modifier should be added to the _repository field declaration. This change ensures that _repository can only be assigned during its declaration or within the constructors of the CatalogueDatasetLinkage class. No other changes are required, as the field is already only assigned in the constructors.

---

To fix the issue, we will simplify the expression autoupdate == true to just autoupdate. This change will make the code more concise and easier to read while maintaining the same functionality. The modification will be applied to line 50 in the constructor of the CatalogueDatasetLinkage class.

To fix the issue, we will replace the if statement on line 37 with a single line using the ternary operator. This will assign the value to the dataset variable based on the condition in a more concise and readable manner. The functionality of the code will remain unchanged.

---

To fix the issue, we will remove the explicit cast to (object) on line 611. The new CatalogueDatasetLinkage(...) expression can be directly cast to (T) without the intermediate cast to (object). This change will simplify the code while maintaining its functionality.

---

To fix the issue, we will remove the explicit cast (object) from the expression new Dataset(repository.CatalogueRepository, "Dataset"). This will allow the implicit conversion to object to occur naturally, as all types in C# derive from object. The functionality of the code will remain unchanged.

---

To fix the issue, we will remove the explicit cast (object) from the expression new PluginDataset(repository.CatalogueRepository, "Plugin Dataset"). This will eliminate the unnecessary upcast while preserving the functionality of the code. The return statement will still cast the result to type T, which is the intended behavior.

---

To fix the issue, we will remove the explicit cast to (object) on line 623. The DatasetProviderConfiguration object can be directly cast to the generic type T without the intermediate cast to object. This change will simplify the code without altering its functionality.

---