Skip to content

Add missing CRITICAL severity filter to Copy Issues panel#20

Merged
shrsv merged 2 commits intomasterfrom
copilot/add-critical-comment-to-copy-issues
Feb 6, 2026
Merged

Add missing CRITICAL severity filter to Copy Issues panel#20
shrsv merged 2 commits intomasterfrom
copilot/add-critical-comment-to-copy-issues

Conversation

Copy link
Contributor

Copilot AI commented Feb 6, 2026

The Copy Issues panel lacked a CRITICAL severity filter despite the backend supporting it. Critical comments were invisible and non-copyable through the UI.

Changes

  • IssuesPanel.js: Added CRITICAL filter button and included 'critical' in default active filters (alongside error, warning)
  • styles.css: Added styling for critical filter button (#dc2626 dark red, consistent with severity hierarchy)

Result

Critical filter added to UI

Critical comments now visible and selectable by default. Filter ordering: CRITICAL → ERROR → WARNING → INFO.

Original prompt

This section details on the original issue you should resolve

<issue_title>Missing Critical Comment in copy issues section.</issue_title>
<issue_description>it would be better to have crtical comment in copy issues (not for copying but also to show user there is 1 critical issues)

  1. Details of the review
gk@jarvis:~/hex/fdt-templ$ cd "/home/gk/hex/fdt-templ" && "/usr/local/bin/lrc" review
Review submitted, ID: 751
Account: ganeshkumar6120@gmail.com
Title: Tranquil Wave
Review link: https://livereview.hexmos.com/#/reviews/751

🌐 Review available at: http://localhost:8000
   Comments will appear progressively as review runs

💡 Press Ctrl-C to abort commit, or Ctrl-S to skip review and commit
Waiting for review completion (poll every 2s, timeout 5m0s)...
Status: completed | elapsed: 28s                                                

📋 Review complete. Choose action:
   [Enter]  Continue with commit
   [Ctrl-C] Abort commit
   Or use the web UI buttons

Enter commit message: 



  1. comments missing in top
Image
  1. Only info comments are present in top comments
Image
  1. Critical comment got missed
Image Image

</issue_description>

<agent_instructions>Check if "critical" is actually missing in the lrc webui (local review ui) and if so - include it.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: shrsv <796107+shrsv@users.noreply.github.com>
return function IssuesPanel({ files, visible, onNavigate, onClose }) {
// Multi-select filters: Set of active severity types (default: error + warning)
const [activeFilters, setActiveFilters] = useState(new Set(['error', 'warning']));
// Multi-select filters: Set of active severity types (default: critical + error + warning)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot I am confused - so how many levels are expected from the LLM side (check the prompt). Support all the labels/levels supported by the LLM prompt/specification for reviews.

Copilot AI changed the title [WIP] Add critical comment in copy issues section Add missing CRITICAL severity filter to Copy Issues panel Feb 6, 2026
Copilot AI requested a review from shrsv February 6, 2026 06:04
@shrsv shrsv marked this pull request as ready for review February 6, 2026 06:05
Copilot AI review requested due to automatic review settings February 6, 2026 06:05
@shrsv shrsv merged commit 65ed4d7 into master Feb 6, 2026
1 check failed
Copilot stopped work on behalf of shrsv due to an error February 6, 2026 06:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the missing CRITICAL severity filter to the Copy Issues panel in the lrc (local review client) web UI. The backend has always supported critical severity comments, but the UI lacked a filter button to show them, making critical comments invisible and non-copyable through the panel.

Changes:

  • Added CRITICAL filter button with count badge and toggle functionality
  • Included 'critical' in default active filters (alongside 'error' and 'warning')
  • Added CSS styling for critical filter button using dark red color (#dc2626)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
cmd/lrc/static/components/IssuesPanel.js Added critical filter button, criticalCount calculation, and included 'critical' in default active filters
cmd/lrc/static/styles.css Added styling for critical filter button with appropriate color hierarchy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Critical Comment in copy issues section.

2 participants