JSON export now includes note mapping for dpcm key#105
Open
nstbayless wants to merge 1 commit intoHertzDevil:masterfrom
Open
JSON export now includes note mapping for dpcm key#105nstbayless wants to merge 1 commit intoHertzDevil:masterfrom
nstbayless wants to merge 1 commit intoHertzDevil:masterfrom
Conversation
|
I believe this repo is abandoned and a community has gathered around the dn-famitracker fork: |
|
if it's abandoned, why isn't the repository archived? |
|
well I stated "I believe" and I don't even know what "archived" means |
Author
|
Well, it seems that Dn-famitracker has removed or never implemented the JSON export option. So it makes the most sense to contribute this PR to 0CC, the only fork of famitracker that has JSON export. I have asked there about this missing feature. In the meantime, anyone looking for a download of 0CC that has this feature can find one here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104
Also resolves an unrelated build issue I was getting. A function was declared in a header, but referenced in a template in that same header before it was used. In Visual Studio 2022, this caused a compile error.