Skip to content

Conversation

@AX3Lino
Copy link
Contributor

@AX3Lino AX3Lino commented Jul 15, 2025

I guess temporally fix, but it works on GTNH 2.8.0-beta-1

@Hermanoid
Copy link
Owner

Hermanoid commented Jul 15, 2025

That's... unexpected, but I'll take your word for it that it works.
That seems to imply that my old code worked in 2.6.1, broke for mystery reasons, and is now working again in 2.8.0-beta1?

@Hermanoid
Copy link
Owner

Hermanoid commented Jul 15, 2025

Build fail is some weird Java spotless/missing method (I love Java I love Java I love Java) that doesn't appear to affect the actual code. I merge.

@Hermanoid Hermanoid merged commit 1db84f3 into Hermanoid:main Jul 15, 2025
1 check failed
@Hermanoid
Copy link
Owner

@AX3Lino, if you got a successful export, would you mind sharing it? I'd like to link a completed recipe export on the front page to save folks some time and trouble.

@AX3Lino
Copy link
Contributor Author

AX3Lino commented Jul 15, 2025

The build need to run on java8, I had the same issue. Also tried export on 2.6.1 (button does not show up) and 2.7.0-beta-3 (works).
notenoughrecipedumps-a4f225e-main+a4f225ef88-dirty-sources.zip
Also tried the NESQL exporter, but it seems it does not work (on 2.8.0-beta-1)

@Hermanoid
Copy link
Owner

Good to know!
Thanks for the build artifacts but I was looking for the JSON recipe artifacts ;)
I want to save the average user from a 2+ hour export.

@AX3Lino
Copy link
Contributor Author

AX3Lino commented Jul 15, 2025

For me it was like 20 mins, and it does show progress, that was much appreciated. Here are the JSON files produced from 2.8.0-beta-1
recipes.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants