implement metrics-aggregator parent chart, defined values #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of metrics-aggregator service using parent / sub chart Helm pattern.
The chart defined in Chart.yaml contains 3 subchart references:
Configuration values in metrics-aggregator/values.yaml are only provided for
datadogwith the intent of matchingconfiguration with currently deployed agent in AWS metrics-aggregator ECS service.
To test the metrics-aggregator chart:
In a subsequent PR, I will add prometheus and river-metrics-discovery with identical configuration as is currently deployed based on terraform config. I will also use make use of subchart template references using
includeto reuse templates from the parent chart in the subchart for river-metrics-discovery which will be defined with custom manifest files in this repo.Update 01/15:
Had to make values changes for datadog, prometheus charts to deprecate unneeded images from the Deployment and allow for GKE Autopilot to work with datadog chart. As of now when running a
helm install metrics-aggregator .on the cluster, datadog agent (as a daemonSet) and prometheus server are both created successfully running in the cluster.Will add river-metrics-discovery service last as a custom subchart Deployment of the image in a ReplicaSet.
Note: We need to make sure we're okay with using the prometheus-community helm chart and associated prometheus image. It seems to be the best maintained one I could find.