Add service name validation #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ert and validation should fail
Author
|
Added that "missing" case in b070528, by calling pytest.raises with a tuple of assertions. |
Owner
|
Hey 👋 For now, you can consider this project unmaintained, unfortunately. I haven't had time to maintain this repo in the last few years, in good parts because I moved home and I haven't had a HomeAssistant setup for a very long time. So I'm a bit disconnected with the latest updates, and it's a huge overhead to start everything again, get context and understand how to fix issues on this project However, I've finally taken the task to set up my server at home again, so I'll probably use this project for my own use again soon. This means I may bring this project up-to-date in the next few months. No guarantees, obviously, but I may. Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #59.
I just couldn't wait.
I do have doubts about one "missing" test case. What if the service name is invalid (that would cause a ValueError) and it has not been called (that would raise AssertionError).
I think I am fine with any of them being called, or both.