-
-
Notifications
You must be signed in to change notification settings - Fork 214
Replaced images with vector drawables #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f11d83a to
1c473c5
Compare
|
The 2 "force-pushed" correspond to :
|
1c473c5 to
ac318a3
Compare
|
To be honest I don't like the new icons, and would like to keep the old ones. Best would be to add a new style (in addition to the current holo & material) with these icons. You could also use this new style to add the more rounded key style from #16. (same goes for the changes emoji icons) Ideally this would be done in a separate PR for better separation of changes. Btw could you add the license for the new icons? I'm planning to add SPDX license identifiers wherever possible (mostly this will change the long license headers to one or 2 lines, also clarifying that GPL 3.0 is used too) |
Don't worry, as I said here #195 (comment) these changes were simply a proposal, with no certainty that they would be approved.
Of course. I prefer to close this PR and I'll do another one more proper. |
|
Alright, just one more thing: before you add another style, could you wait a little? |
|
Oh, I just noticed updating the license headers created some merge conflicts... sorry for that. I removed the holo no border theme, changing key transparency plus some workaround for the spacebar is sufficient. The material theme is a bit more complicated and thus the division into base and border will remain. |
700e792 to
f8f7444
Compare
Don't worry; this PR is too messy anyway. |
|
Alright. Btw now with the new color settings it should be very easy to expose all colors to the user, as you had wished, while still defaulting to automatic color selection. You can do a PR, or I might do it at some later point. |
I'll do it because I don't like not finishing what I've started 😅
Great. I'll take a look and keep you informed. 👍 |
@Helium314: I'll keep you informed as promised: Finally, I need to separate the use of the new icons because I forgot you'd rather have 2 separate PR 😅 Screenshots of current state : (space bar icon in Numpad view will be replaced)
|
The new icons and rounded keys both belong to the same style, right? So I think it's very much ok to have them in the same PR. |


Fixes #195
Almost all the images included in the
drawable-folders have been replaced by vector drawables.Moreover, Material style icons now use the Material design.
The following images are concerned:
Expand to see images concerned
In android studio, some images look a little imperfect (because I created them myself from PNG files), but it's impossible to distinguish these imperfections on a tablet or phone (see screenshots below).
Expand to see affected images
Expand to see screenshots after modifications
Tested on Huawei phone with Android 10 and Samsung tablet with Android 13.