Centralize keyboard typeface resolution for custom font consistency#2400
Open
qappell wants to merge 1 commit intoHeliBorg:mainfrom
Open
Centralize keyboard typeface resolution for custom font consistency#2400qappell wants to merge 1 commit intoHeliBorg:mainfrom
qappell wants to merge 1 commit intoHeliBorg:mainfrom
Conversation
Contributor
|
LGTM. |
Author
|
5d0431d#diff-a4bba161d18828603627128e37b4e126212363e5a20ff96ea42aba1c4cf2f9a4R487-R489 caused the regression. Functionality and appearance are identical to v3.6 (except for the new emoji menu of course). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2314 and #2368 by consolidating the typeface and emoji font resolution into a single helper class, KeyboardTypeface.kt, and makes sure that custom UI and emoji fonts load consistently across all keyboard components (if I didn't miss anything). This doesn't fix any of the font issues with text getting cut off in the suggestions bar or overlapping emoticons, like in #1837, but I'll try to make time to fix it later.
I am not an Android developer, and I have used AI extensively to help structure this refactor and ensure the Kotlin/Java interop was correct. However, I have manually tweaked the AI-generated logic and compiled and ran the app multiple times using ./gradlew assembleDebug on a Windows environment to verify that both the standard keyboard views and the Compose-based search activities render fonts as expected.