Open
Conversation
Since using this keyboard a major issue i've found is how easy it is to accidentally write concatenated words where I accidentally press a letter instead of the space bar. I'm constantly writing c, v, b, n, and m (bottom row keys) instead of space leading to words like "hellobthere" or "whatbarenyouvdoingvtonight?" My proposal is adding a setting which would correct for this specific issue by trying to split unknown words by the trouble keys and testing for dictionary values in the split words. In my own testing this works great and my number of mispells and retypes has gone down drastically. An alternative fix for this is to enlarge the whole keyboard thus increasing padding around the space bar, but it affects ergonomics and what you can read on screen. Another possibility is to enlarge the space bar but that also affects screen size. This was not an issue with major competing keyboards as I suspect they either correct using their own proprietary models, or they do something similar to this change. I have no intention of using those keyboards so I believe Heliboard should be able to solve the problem. I believe this solution is a better enhancement and provides for a good user experience when enabled.
Collaborator
|
Ideally this should be taken care of by the library, but apparently it isn't...
You can just increase the bottom padding, that only shifts the keyboard. But if you want this functionality, it should be independent of the keyboard layout, i.e. use the current bottom keys instead of assuming a particular layout. Thanks for making the code nicely contained and adding tests! |
Collaborator
|
Btw aren't the split words often already in the suggestions, maybe just with a low score? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since using this keyboard a major issue i've found is how easy it is to accidentally write concatenated words where I accidentally press a letter instead of the space bar. I'm constantly writing c, v, b, n, and m (bottom row keys) instead of space leading to words like "hellobthere" or "whatbarenyouvdoingvtonight?"
My proposal is adding a setting which would correct for this specific issue by trying to split unknown words by the trouble keys and testing for dictionary values in the split words. Using a version with this fix works great and my number of mispells and retypes has gone down drastically.
An alternative fix for this is to enlarge the whole keyboard thus increasing padding around the space bar, but it affects ergonomics and what you can read on screen. Another possibility is to enlarge the space bar but that also affects screen size.
This was not an issue with major competing keyboards as I suspect they either correct using their own proprietary models, or they do something similar to this change. I have no intention of using those keyboards so I believe Heliboard should be able to solve the problem. I believe this solution is a better enhancement and provides for a good user experience when enabled.
Not sure what the usual testing is but i confirmed my tests pass against Android platform 35 + OpenJDK 17.0.16