Project Solution: read the ReadMe file for more information#43
Open
afmarquezm11 wants to merge 1 commit intoHedgeApple:masterfrom
Open
Project Solution: read the ReadMe file for more information#43afmarquezm11 wants to merge 1 commit intoHedgeApple:masterfrom
afmarquezm11 wants to merge 1 commit intoHedgeApple:masterfrom
Conversation
john-parton
reviewed
May 16, 2024
| } | ||
|
|
||
|
|
||
| def create_box_columns() -> dict: |
john-parton
reviewed
May 16, 2024
| return float(sub("^\$", "", x)) | ||
| if isinstance(x, float): | ||
| return x | ||
| except: |
Contributor
There was a problem hiding this comment.
Catch a more specific exception.
john-parton
reviewed
May 16, 2024
| return "" | ||
|
|
||
|
|
||
| def update_ean13(x: str) -> str: |
Contributor
There was a problem hiding this comment.
It would be nice to validate the check digit.
john-parton
reviewed
May 16, 2024
| return "" | ||
|
|
||
|
|
||
| def update_ean13(x: str) -> str: |
Contributor
There was a problem hiding this comment.
What happens if x == -1 ?
john-parton
reviewed
May 16, 2024
| str: the country in alpha3 format or "" if it encounters an issue | ||
| """ | ||
| try: | ||
| return country_name_to_country_alpha3(x) |
Contributor
There was a problem hiding this comment.
I like that you used a 3rd party library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to the README.md file where each step is briefly described. All functions are commented, in the main method, you'll find additional comments for each step.