Skip to content

Fix formatting for offensive matches in MatchCard & MatchTable #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
realist-hll wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix formatting for offensive matches in MatchCard & MatchTable #376

realist-hll wants to merge 3 commits into from

Conversation

@realist-hll
Copy link

@realist-hll realist-hll commented Oct 22, 2022

  • Fixes MatchCard WinLoseBanner (some victories defaulted to Defeat)
  • Fixes offensive mode formatting in MatchCard, e.g. Warfare, Offensive
  • Introduce "Mode" column on Match table, e.g. Warfare, Offensive
  • Reintroduce "Result" column on Clan page

@vercel
Copy link

vercel bot commented Oct 22, 2022

Someone is attempting to deploy a commit to the helo-system Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nextjs-helo-app ❌ Failed (Inspect) Jan 30, 2023 at 6:16PM (UTC)

hoersamu
hoersamu reviewed Oct 23, 2022
View reviewed changes
src/components/MatchesTable/MatchesTable.tsx
},
sortable: true,
},
].filter(Boolean);
Copy link
Member

@hoersamu hoersamu Oct 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's that line supposed to do?

Copy link
Author

@realist-hll realist-hll Oct 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It filters out the result column if null was returned, i.e. when clanId is undefined, e.g. on the matches page, rather than the clans/[cid] page.

Since the "result" column only makes sense on a clans/[cid] match archive table, but not on the matches/ match archive table.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoersamu hoersamu hoersamu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@realist-hll @hoersamu