Skip to content

Fixed BaseComponent integration #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LogGits wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixed BaseComponent integration #40

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
534fe1d
Fixed Basecomponent integration
LogGits Nov 22, 2019
bfc28ff
Type cast
LogGits Nov 23, 2019
c1ba8b8
3rd time's a lucky charm
LogGits Nov 23, 2019
77c7a08
it's 5am dont judge me.
LogGits Nov 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions src/main/java/com/hazebyte/crate/api/util/Messenger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,20 +61,11 @@ public static boolean tell (Player player, String msg) {
return tell((CommandSender) player, msg);
}

public static boolean tell(CommandSender sender, BaseComponent msg) {
return tell(sender, msg, null); // Hack to handle overloading call
}

public static boolean tell (CommandSender sender, BaseComponent... msg) {
if (sender == null || msg == null) {
public static boolean tell (CommandSender sender, BaseComponent... components) {
if (sender == null || components == null) {
return false;
}

for (BaseComponent m : msg) {
if (m instanceof TextComponent) {
tell(sender, (TextComponent) m);
}
}
sender.spigot().sendMessage(components);
Copy link
Collaborator

@imWillX imWillX Nov 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't compatible with spigot 1.8.

CommandSender does not have a spigot field, unfortunately.

return true;
}

Expand Down