Do not free globals when threads are enabled #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobil4sk
force-pushed
the
fix/threads-crash-global-free
branch
from
256f845 to
7d10f27
Compare
When threads are enabled, it's possible that other threads are still running while neko is shutting down. This means freeing builtins or the thread local storage slot for the vm context may cause a crash on those threads.
7 tasks
Member
|
Should I merge this? I thought there were potential problems here, but maybe I'm confusing this with #305. |
Member
Author
|
You mentioned a concern about whether it's correct to not free any globals at all here, but it was #305 (not this one) with issues for the haxelib server. |
|
So could we get a neko release? That would allow me to release Haxe 4.3.7 |
Member
|
Who is able to do that? |
Member
Author
|
2.4.1 has been released with this fix: https://github.com/HaxeFoundation/neko/releases/tag/v2-4-1, and I've opened a PR for haxe to use this new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When threads are enabled, it's possible that other threads are still running while neko is shutting down. This means freeing builtins or the thread local storage slot for the vm context may cause a crash on those threads.
Closes #281.