Conversation
Contributor
|
The change to db.py is good. Perhaps move that chance into another branch and then generate a PR just for that change. This way this fix is not blocked waiting the infrastructure class to be reviewed and tested. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The view/infrastructure.py is edited copy of views/providers.py
There is a lot of same code for all providers and some variant strings (url, provider name, check messages).
Imo there could be used inheritance for all providers, but that would mean refactoring provdiers.py and possibly all its usages so i did not touch that.
My steps for changing it would be:
The coverage of polarion testcases is still missing and im working on them (due to issues with wrong and unavailable hostname for RHEVM im waiting for response from mpusateri on how to handle that).
I would also change the common/db.py so there would not be the check on lines 61-66 and the method would consume provider type.
The INFRA_TEST_VM_NAME param in conf/properties.properties is for INV008 testcases, all of them run on 1 VM and may be many other test VMs (not just ours).