fix: contentDetail 화면에서 header position이 absolute로 설정되어 있어, 콘텐츠 블록하고 겹치던 문제 해결

[qkrwoghd04]

Summary by CodeRabbit

• Style

  • Adjusted layout and sizing of feedback and settings sections for improved spacing and container behavior.
  • Updated header's scrolled state with increased vertical padding.
  • Modified mail header positioning for more consistent layout.

• Documentation

  • Updated meta description to better reflect the daily cultural insight service.
  • Simplified image preload attributes for improved performance.

• Chores

  • Removed inline comments and emoji icons from workflow test result labels for a cleaner appearance.

[coderabbitai]

Walkthrough

This set of changes updates styling and metadata across several frontend components and configuration files. Modifications include adjustments to container heights, padding, and positioning in React components, updates to the meta description and image preload attributes in the HTML, and removal of inline comments and emojis from a GitHub Actions workflow file. No logic or control flow was altered.

Changes

Cohort / File(s)	Change Summary
Workflow Comment & Emoji Cleanup .github/workflows/E2ETest_Lighthouse.yml	Removed all inline Korean comments and emojis from workflow steps and PR comment formatting.
Meta & Image Preload Update index.html	Updated meta description for clarity and removed fetchpriority="high" from logo image preload link.
Feedback Section Height Adjustment src/features/feedback/FeedbackSection.jsx	Changed container from min-height: 100vh to height: 90vh.
Setting Section Layout Tweak src/features/setting/SettingSection.jsx	Changed container height from 100vh to 100% and reduced vertical margin in content wrapper.
Header Padding Adjustment src/layout/Header.jsx	Increased .scrolled class vertical padding from 15px to 20px.
Mail Header Positioning src/layout/MailHeader.jsx	Changed header container positioning from absolute to relative.

Sequence Diagram(s)

No sequence diagram generated as all changes are limited to styling, metadata, and comment/formatting updates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

• add: 검색엔진최적화를 위한 robots.txt 추가 및 index.html meta 데이터 추가 #108: Also modifies the meta description in index.html for SEO, directly related to the meta tag changes here.
• LCP 최적화를 위한 Haruhan 로고 이미지 우선 로딩 설정 #86: Previously added fetchPriority='high' to the logo image preload, which is now being removed in this PR.

Poem

A bunny hopped through lines of code,
Adjusted heights and padding load.
Meta tags now clearer read,
Emojis gone, the tests proceed.
With headers neat and margins tight,
This code now fits just right!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

E2E Test & Lighthouse Report

Category	Result
Tests
Total	20
Passed	20
Failed	0
Lighthouse
Performance	98
Accessibility	63
SEO	92
LCP	0.97s

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/features/setting/SettingSection.jsx (1)

16-18: Margin reduction looks fine but verify small-screen spacing

Shrinking the vertical margin from 4rem to 1rem alleviates the collision with an absolute header, but it also tightens breathing room on mobile. Double-check the visual density at the smallest breakpoints; you may want to keep a slightly larger top margin (e.g., 2rem) below 768px.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02f9e76 and 6daba8a.

📒 Files selected for processing (6)

• .github/workflows/E2ETest_Lighthouse.yml (1 hunks)
• index.html (1 hunks)
• src/features/feedback/FeedbackSection.jsx (1 hunks)
• src/features/setting/SettingSection.jsx (1 hunks)
• src/layout/Header.jsx (1 hunks)
• src/layout/MailHeader.jsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: e2e-and-lighthouse

🔇 Additional comments (7)

index.html (2)

7-7: Improved meta description specificity.

The updated meta description provides clearer information about Haruhan being a subscription service that delivers daily cultural insights, which is more specific and informative than the previous general description.

---

14-14: Simplified image preload directive.

Removing the fetchpriority="high" attribute simplifies the preload link. This attribute has limited browser support and may not be necessary for this use case.

.github/workflows/E2ETest_Lighthouse.yml (1)

81-86: Cleaner PR comment formatting.

Removing emojis from the test results and Lighthouse score labels creates a more professional and consistent reporting format while maintaining all functional information.

src/layout/Header.jsx (1)

29-29: Increased vertical padding for better spacing.

The padding adjustment from 15px 40px to 20px 40px increases vertical spacing in the scrolled header state, which improves visual balance and spacing consistency.

src/layout/MailHeader.jsx (1)

10-10: Fixed header overlap issue by changing positioning.

Changing from position: absolute to position: relative directly addresses the PR objective by preventing the header from overlapping content blocks. With relative positioning, the header remains in the document flow instead of being positioned independently, eliminating the overlap issue mentioned in the contentDetail screen.

src/features/feedback/FeedbackSection.jsx (1)

15-15: Adjusted container height for better layout integration.

Changing from min-height: 100vh to height: 90vh fixes the container to 90% of viewport height instead of allowing it to expand beyond the full viewport. This adjustment likely complements the header positioning changes by ensuring proper space allocation and preventing layout conflicts.

src/features/setting/SettingSection.jsx (1)

8-13: height: 100% may break vertical-centering when the parent has no explicit height

Flex-centering (align-items: center) relies on the flex container having a determinable cross-axis size.
With height: 100%, that size collapses to “auto” unless every ancestor up to html, body also has height: 100%. If any parent omits it (common in real pages), the section will no longer fill the viewport and the content will sit at the top, re-introducing the overlap problem in a different form.

Consider a safer fallback:

-  height: 100%;
+  /* Stretch at least full viewport height while still allowing the content to grow */
+  min-height: 100vh;

or ensure html, body, #root all have height: 100% in the global stylesheet.

Please confirm which approach is enforced globally so we don’t regress layout on pages that mount this component outside the contentDetail context.