change the get_auth function signature to use a bare * instead of *_, so that the function requires keyword-only args without introducing an untyped varargs parameter.
#53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `*_,` so that the function requires keyword-only args without introducing an untyped varargs parameter. Why: - Currently `get_auth` is defined as `def get_auth(*_, client_id: str, ...)` which accepts arbitrary positional args via `*_`. - The untyped varargs show up to type-checkers (Pylance/Pyright) as `Unknown` and leads to diagnostics like `reportUnknownVariableType` in consumer projects (even when `python.analysis.useLibraryCodeForTypes` is enabled). - Replacing `*_,` with `*` keeps the function semantics (forces subsequent parameters to be keyword-only) without introducing an untyped parameter that causes analyzer warnings.
Owner
HarryMWinters
left a comment
HarryMWinters
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this. Once the other PR is merged I'll cut a release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_authis defined asdef get_auth(*_, client_id: str, ...)which accepts arbitrary positional args via*_.Unknownand leads to diagnostics likereportUnknownVariableTypein consumer projects (even whenpython.analysis.useLibraryCodeForTypesis enabled).*_,with*keeps the function semantics (forces subsequent parameters to be keyword-only) without introducing an untyped parameter that causes analyzer warnings.Closes #52