Wrap NoResultException Doctrine exception in EntitySpecificationRepositoryTrait #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-gribanov
force-pushed
the
doctrine_exceptions
branch
from
ee10de9 to
40025eb
Compare
peter-gribanov
force-pushed
the
doctrine_exceptions
branch
from
40025eb to
d817623
Compare
peter-gribanov
force-pushed
the
doctrine_exceptions
branch
from
d817623 to
683c78e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Doctrine\ORM\AbstractQuery::getSingleScalarResult()andDoctrine\ORM\AbstractQuery::getScalarResult()methods can throwDoctrine\ORM\NoResultExceptionwat should be wrpped inHappyr\DoctrineSpecification\Exception\NoResultException.