Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This pull request fixes a critical bug in chess board rendering where the turn indicator was captured before undo operations, resulting in stale board state. It also corrects a React JSX attribute for proper compatibility.
- Replaced stale
turnvariable with dynamicchess.turn()calls to reflect the current game state after undo operations - Updated JSX attribute from
http-equivtohttpEquivfor React compatibility
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lichess.ts | Fixed turn tracking by using chess.turn() dynamically instead of capturing it before undo operations, ensuring accurate board state at the position of interest |
| pages/_document.tsx | Corrected meta tag attribute to use camelCase httpEquiv instead of http-equiv for proper React/JSX syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily addresses a bug in the chess board processing logic and makes a minor correction to HTML attribute casing for compatibility. The most important changes are grouped below:
Chess board processing logic fixes:
turnvariable inprocessGamewithinlichess.tsto ensure the current turn is always retrieved from the chess instance, preventing stale or incorrect board state during undo operations.turnvalue in the returned board object to usechess.turn(), ensuring consistency with the actual game state.HTML attribute casing correction:
http-equivattribute tohttpEquivin the meta tag withinpages/_document.tsxfor React compatibility and to prevent potential rendering issues.