Fix CI mypy errors and add pre-commit hooks#2
Merged
HanssonMagnus merged 3 commits intomainfrom Nov 9, 2025
Merged
Conversation
- Fix type annotations: change Optional[click.DateTime] to Optional[datetime.datetime] - Fix import sorting in converters (datetime before typing) - Remove unused import in test_workflow.py - Add .pre-commit-config.yaml with hooks matching CI pipeline - Add pre-commit to dev dependencies - Add pre-commit hooks documentation to README - Format code with black
These scripts are now redundant since pre-commit hooks run all the same checks. Pre-commit hooks provide a better developer experience and ensure consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
This PR fixes the CI pipeline failures and adds pre-commit hooks to run the full CI pipeline locally.
Changes
Optional[click.DateTime]toOptional[datetime.datetime]in CLI functionsconvert_pdfsimport from test_workflow.py.pre-commit-config.yamlwith hooks matching CI pipeline:pre-commit>=3.0.0topyproject.tomlVerification
All pre-commit hooks pass:
This ensures the CI pipeline will pass and developers can catch issues locally before pushing.