Refactor/162 rename application #165
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR renames terminology throughout the codebase from "Application" to "Enrollment" to better reflect the domain's purpose. The changes are systematic and comprehensive, updating component names, interfaces, function names, file paths, and routing across the entire application.
- Renamed components, interfaces, and functions from "Application" to "Enrollment" for improved clarity
- Updated all file paths and route definitions from
/applicationto/enrollment - Removed unused
styled-componentsdependency from package.json
Reviewed Changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/StudyEnrollment/components/StudyEnrollmentForm.tsx | Renamed form component and all related interfaces/variables from "Application" to "Enrollment" |
| src/pages/StudyEnrollment/components/StepReviewSubmit.tsx | Updated props interface to use enrollmentData instead of applicationData |
| src/pages/StudyEnrollment/components/StepAddFriend.tsx | New file implementing friend addition step for enrollment |
| src/pages/StudyEnrollment/components/StepAddCourses.tsx | New file implementing course addition step for enrollment |
| src/pages/StudyEnrollment/Page.tsx | Renamed page component and updated variable names to use enrollment terminology |
| src/pages/OverviewEnrollment/Page.tsx | Renamed page component and updated all state/variable references to enrollment terminology |
| src/pages/Admin/ManageStudent/Page.tsx | Renamed variables from "applicant" to "enrollee" for consistency |
| src/pages/Admin/ManageGroup/Page.tsx | Updated API function name from readApplicants to readEnrollees |
| src/pages/Admin/CreateGroup/Page.tsx | Renamed variables and functions from "applicant" to "enrollee" |
| src/const/paths.ts | Updated path constants from /application to /enrollment |
| src/components/SideBar.tsx | Updated navigation link to use new enrollment path |
| src/components/PrivateRoute.tsx | Updated route validation to use new enrollment path |
| src/components/ARouter.tsx | Updated route definitions and lazy imports for enrollment pages |
| src/apis/study.ts | Renamed API functions and interfaces from "Enroll" to "Enrollment" for clarity |
| src/apis/manager.ts | Renamed readApplicants to readEnrollees |
| package.json | Removed unused styled-components dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| data: enrollees, | ||
| refetch, | ||
| isLoading, | ||
| } = useQuery(['allStudyApplyUsers'], readAllStudyApplyUsers, { |
There was a problem hiding this comment.
| } = useQuery(['allStudyApplyUsers'], readAllStudyApplyUsers, { | |
| } = useQuery(['allStudyEnrollmentUsers'], readAllStudyEnrollmentUsers, { |
해당 부분의 apply를 enrollment로 변경 하는 것은 어떨까요??
There was a problem hiding this comment.
제가 놓친 부분이 있네요. 감사합니다.
readAllStudyEnrollmentUsers도 좋지만, 사용하고 있던 Enrollees를 활용하여 readAllStudyEnrollees로 변경하겠습니다.
| }); | ||
|
|
||
| const [editingId, setEditingId] = React.useState<number | null>(null); | ||
| const [formData, setFormData] = React.useState<Partial<StudyApplyUser>>({}); |
There was a problem hiding this comment.
| const [formData, setFormData] = React.useState<Partial<StudyApplyUser>>({}); | |
| const [formData, setFormData] = React.useState<Partial<StudyEnrollmentUser>>({}); |
위와 마찬가지로 apply -> enrollment 수정이 필요합니다.
There was a problem hiding this comment.
해당 부분도 위와 동일하게 적용하겠습니다.
|
|
||
| const handleEdit = (applicant: StudyApplyUser) => { | ||
| setEditingId(applicant.id); | ||
| const handleEdit = (enrollee: StudyApplyUser) => { |
There was a problem hiding this comment.
| const handleEdit = (enrollee: StudyApplyUser) => { | |
| const handleEdit = (enrollee: StudyEnrollmentUser) => { |
해당 부분도 마찬가지로 apply -> enrollment를 적용해주세요!
|
@minzziPark 고생하셨습니다! 빠뜨린 부분은 코멘트 남겨두었으니 확인 부탁드립니다. |
작업 사항
스터디 신청 키워드 변경
application->enrollment스터디 신청자 키워드 변경
applicant->enrollee기존에는 스터디 신청 키워드가 application, applicant로 사용되고 있었습니다.
처음 보는 사람에게는 'App'이라는 의미로 잘못 해석될 여지가 있어서 enrollment로 수정합니다.
관련 이슈
close #162
Copilot
Please review this PR as if you were a senior developer and provide constructive feedback on code quality, structure, and naming.