[Feature] Community 게시글 조회 및 상세보기 API 연동#26
Merged
Conversation
응답 타입과 에러 타입을 위해 NetworkCommon 타겟을 만들었으나, Interface와 역할이 다른 점이 명확하지않아 통합 NetworkImpl과 NetworkInterface로 분리하는 것은 의존성을 위함이었는데, baseURL 로 인해 그 규칙이 깨져, NetworkInterface에 NetworkConfig를 추가하여 규칙대로 코드 수정
kangddong
changed the title
# Conflicts: # Common/Package.swift # Community/Package.swift # Community/Sources/Data/Repositories/CommunityRepositoryImpl.swift # Community/Sources/Domain/Repositories/CommunityRepositoryInterface.swift # Community/Sources/Domain/UseCases/GetBoardsUseCase.swift # DI/Package.swift # Hambug.xcodeproj/project.pbxproj # Home/Package.swift # Home/Sources/Data/DTO/TrendingPostResponse.swift # Infrastructure/Sources/NetworkInterface/NetworkConfig.swift # Infrastructure/Sources/NetworkInterface/NetworkServiceInterface.swift # Login/Sources/Data/LoginRepositoryImpl.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
어떤 작업을 했나요 ?
작업 결과