Skip to content
This repository was archived by the owner on Nov 14, 2025. It is now read-only.

Conversation

@BeatSeat
Copy link

@BeatSeat BeatSeat commented Oct 7, 2025

  • chore: migrate to claude agent sdk

  • feat: add CI workflow to build VSIX package

Summary by Sourcery

Migrate the codebase from the deprecated claude-code SDK to the new claude-agent-sdk, add system prompt customization and enrich webview messages with metadata, and introduce a CI workflow to build and package the VSIX extension.

New Features:

  • Allow custom or appended system prompts when no override is provided
  • Surface system message metadata (model, agents, tools, cwd, permissionMode, apiKeySource) in webview

Enhancements:

  • Replace all imports and build logic from '@anthropic-ai/claude-code' to '@anthropic-ai/claude-agent-sdk'
  • Update esbuild configuration to copy the CLI from the new agent SDK

CI:

  • Add GitHub Actions workflow to build, package, and upload the VSIX extension

* chore: migrate to claude agent sdk

* feat: add CI workflow to build VSIX package
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 7, 2025

Reviewer's Guide

This PR migrates the extension from the deprecated ‘claude-code’ SDK to the new ‘claude-agent-sdk’, enriches session configuration and system message handling, and adds a CI workflow for building and packaging the VSIX extension.

File-Level Changes

Change Details Files
Migrate SDK usage from claude-code to claude-agent-sdk
  • Replace all imports from '@anthropic-ai/claude-code' with '@anthropic-ai/claude-agent-sdk'
  • Update dynamic import of query to use the new SDK module
  • Adjust esbuild plugin to copy the CLI from the new SDK package
  • Bump dependency in package.json to the new SDK version
  • Update global type comment to reference the new SDK
src/services/claude/claude.ts
webview/src/services/messageBus.ts
webview/types/messages.ts
webview/src/utils/messageUtils.ts
esbuild.js
package.json
src/services/claude/types.ts
src/types/global.d.ts
Add configurable systemPrompt logic in session options
  • Introduce retrieval of customSystemPrompt and appendSystemPrompt from config
  • Conditionally set options.systemPrompt to either a custom string or a preset with appended text
src/services/claude/claude.ts
Capture and surface additional system message metadata
  • Extend WebviewMessageBus to include metadata fields (model, permissionMode, tools, cwd, agents, apiKeySource)
  • Augment MessageMetadata type to declare the new metadata properties
webview/src/services/messageBus.ts
webview/types/messages.ts
Enhance system message text formatting
  • Append agent and tool information to the system initialization message text
webview/src/utils/messageUtils.ts
Add GitHub Actions workflow for VSIX build and packaging
  • Create a CI workflow to install dependencies, build assets, compile the extension, package a VSIX, and upload it as an artifact
.github/workflows/build.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

Blocking issues:

  • An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)

General comments:

  • Consider extracting the systemPrompt override logic into a dedicated helper to reduce nesting and improve readability in the session initialization.
  • Add a guard or fallback for workspaceService.getWorkspaceFolders().at(0) returning undefined so cwd is never passed as undefined into the SDK options.
  • Centralize the '@anthropic-ai/claude-agent-sdk' import path (and its CLI resolution) into a shared constant or config to simplify future SDK swaps and avoid duplication.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider extracting the systemPrompt override logic into a dedicated helper to reduce nesting and improve readability in the session initialization.
- Add a guard or fallback for workspaceService.getWorkspaceFolders().at(0) returning undefined so cwd is never passed as undefined into the SDK options.
- Centralize the '@anthropic-ai/claude-agent-sdk' import path (and its CLI resolution) into a shared constant or config to simplify future SDK swaps and avoid duplication.

## Individual Comments

### Comment 1
<location> `.github/workflows/build.yml:16` </location>
<code_context>
        uses: pnpm/action-setup@v3
</code_context>

<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

*Source: opengrep*
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

uses: actions/checkout@v4

- name: Setup pnpm
uses: pnpm/action-setup@v3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha): An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

Source: opengrep

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant