This repository was archived by the owner on Nov 14, 2025. It is now read-only.
feat(model): implement dynamic model selection with custom model support #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'claudex.customModel' configuration for user-defined model list - Implement config watcher in ClaudeClient to push model updates to webview - Support model parameter in chat/send request payload - Add reactive modelState in messageBus for global model selection - Render model dropdown dynamically from system/ready payload - Add "Manage Models" entry to open settings page directly This feature allows users to configure custom models via settings and switch between them seamlessly in the chat interface. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Reviewer's GuideThis PR adds dynamic model selection by introducing a custom model configuration and watcher in the extension that pushes updated model lists and the selected model to the webview, extends the chat/send flow to include the model parameter, and implements a reactive global modelState in the webview to render a dynamic dropdown and open settings directly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/services/claude/client.ts:70-75` </location>
<code_context>
+ e.affectsConfiguration('claudex.model')
+ ) {
+ const cfg2 = vscode.workspace.getConfiguration('claudex');
+ const custom2 = (cfg2.get<string>('customModel') || '')
+ .split(',')
+ .map(s => s.trim())
+ .filter(Boolean);
+ const models2 = Array.from(new Set([...builtInModels, ...custom2]));
+ const selected2 = cfg2.get<string>('model') || models2[0] || 'claude-4-sonnet';
</code_context>
<issue_to_address>
**suggestion:** Consider normalizing model names to avoid duplicates due to whitespace or casing.
Trimming and filtering helps, but without normalizing case or whitespace, users may still create duplicate model entries. Consider converting names to lower case or documenting the expected format.
```suggestion
const custom2 = (cfg2.get<string>('customModel') || '')
.split(',')
.map(s => s.trim().toLowerCase())
.filter(Boolean);
const models2 = Array.from(new Set([...builtInModels.map(m => m.toLowerCase()), ...custom2]));
const selected2 = (cfg2.get<string>('model') || models2[0] || 'claude-4-sonnet').toLowerCase();
```
</issue_to_address>
### Comment 2
<location> `webview/src/services/messageBus.ts:228-229` </location>
<code_context>
+ // 更新模型列表
+ if (Array.isArray(message.payload.models)) {
+ const newOptions = message.payload.models.slice();
+ modelState.options = newOptions;
+
+ // 如果当前选择不在新列表里，则回退到推荐或第一个
</code_context>
<issue_to_address>
**suggestion:** Direct assignment to reactive array may not trigger reactivity in some cases.
If UI updates are inconsistent, try replacing the array contents with splice: modelState.options.splice(0, modelState.options.length, ...newOptions).
```suggestion
const newOptions = message.payload.models.slice();
modelState.options.splice(0, modelState.options.length, ...newOptions);
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+70
to
+75
| const custom2 = (cfg2.get<string>('customModel') || '') | ||
| .split(',') | ||
| .map(s => s.trim()) | ||
| .filter(Boolean); | ||
| const models2 = Array.from(new Set([...builtInModels, ...custom2])); | ||
| const selected2 = cfg2.get<string>('model') || models2[0] || 'claude-4-sonnet'; |
There was a problem hiding this comment.
suggestion: Consider normalizing model names to avoid duplicates due to whitespace or casing.
Trimming and filtering helps, but without normalizing case or whitespace, users may still create duplicate model entries. Consider converting names to lower case or documenting the expected format.
Suggested change
| const custom2 = (cfg2.get<string>('customModel') || '') | |
| .split(',') | |
| .map(s => s.trim()) | |
| .filter(Boolean); | |
| const models2 = Array.from(new Set([...builtInModels, ...custom2])); | |
| const selected2 = cfg2.get<string>('model') || models2[0] || 'claude-4-sonnet'; | |
| const custom2 = (cfg2.get<string>('customModel') || '') | |
| .split(',') | |
| .map(s => s.trim().toLowerCase()) | |
| .filter(Boolean); | |
| const models2 = Array.from(new Set([...builtInModels.map(m => m.toLowerCase()), ...custom2])); | |
| const selected2 = (cfg2.get<string>('model') || models2[0] || 'claude-4-sonnet').toLowerCase(); |
Comment on lines
+228
to
+229
| const newOptions = message.payload.models.slice(); | ||
| modelState.options = newOptions; |
There was a problem hiding this comment.
suggestion: Direct assignment to reactive array may not trigger reactivity in some cases.
If UI updates are inconsistent, try replacing the array contents with splice: modelState.options.splice(0, modelState.options.length, ...newOptions).
Suggested change
| const newOptions = message.payload.models.slice(); | |
| modelState.options = newOptions; | |
| const newOptions = message.payload.models.slice(); | |
| modelState.options.splice(0, modelState.options.length, ...newOptions); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows users to configure custom models via settings and switch between them seamlessly in the chat interface.
🤖 Generated with Claude Code
Summary by Sourcery
Implement dynamic model selection with custom model support by introducing a new configuration setting, watching for setting changes, extending the messaging protocol, and updating the UI to render and switch between models dynamically.
New Features:
Enhancements: