Conversation
Methy659
commented
Jun 28, 2022
| spec: | ||
| containers: | ||
| - name: client | ||
| image: hakimixx/docker-infra-client:v1.1 |
Collaborator
Author
There was a problem hiding this comment.
vær opmærksom her
HakimiX
reviewed
Jun 29, 2022
Comment on lines
+4
to
+5
| echo $CURRENT_PATH | ||
| echo $CURRENT_PATH | rev | cut -d "/" -f1 | rev |
| first_deploy() { | ||
| minikube start | ||
| minikube addons enable ingress | ||
| eval $(minikube docker-env) |
Owner
There was a problem hiding this comment.
Double quote here as well.
Generally quote everything (unless it's a numerical value) where you do not require the shell to perform word splitting.
Comment on lines
+40
to
+43
| echo | ||
| echo | ||
| echo | ||
| echo sometimes it gets stuck just do ctrl + c on it, do verify by refreshing website. |
Owner
There was a problem hiding this comment.
Perhaps replace these lines with:
echo $'\nIn case the script is stuck, simply terminate and verify by refreshing the client'| echo $CURRENT_PATH | ||
| echo $CURRENT_PATH | rev | cut -d "/" -f1 | rev | ||
| FILES=(client-deployment.yml server-deployment.yml worker-deployment.yml) | ||
| PATH_OF_DOCKERFILES=$(echo $CURRENT_PATH | rev | cut -d "/" -f1 | rev) |
| clean: | ||
| echo Deletes all local Kubernetes cluster. This command deletes the VM, and removes all associated files. | ||
| minikube stop | ||
| minikube delete --all |
Owner
There was a problem hiding this comment.
How about creating a minikube profile which allows us to manage multiple minikube instances.
That way we don't terminate other minikube instances (applications running) by executing minikube stop.
minikube start -p docker-infrastructure
minikube profile docker-infrastructureAnd perhaps add a stop step, that simply stops the current instance and doesn't delete it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for minikube for Mac