Skip to content

Conversation

@srak289
Copy link
Contributor

@srak289 srak289 commented Nov 10, 2025

This merge creates the carthage.libvirt plugin which operates the same as carthage/vm.py.
We create an import shim at carthage.vm for backwards-compatability that prints a warning.

@hartmans
Copy link
Member

@srak289 Why do you import carthage.libvirt in carthage.init?
It seems undesirable to import the plugin but not to enable it.

@srak289
Copy link
Contributor Author

srak289 commented Nov 17, 2025

@hartmans carthage/__init__ originally imported carthage.vm and setup the LibvirtDeployableFinder. I had originally updated the references to point to carthage.libvirt, but since libvirt is now a plugin the plugin's init handles that. I'll remove the import from the top-level.

@srak289 srak289 force-pushed the srak/libvirt-plugin branch 2 times, most recently from 197cbcd to 83bfce5 Compare November 17, 2025 17:19
Spencer Rak added 5 commits November 17, 2025 12:19
    * Move vm.py -> libvirt/base.py
    * Create import shim with warnings for importers of carthage.vm
    * Add libvirt plugin initialization
    * Move libvirt ConfigSchema to libvirt plugin
    * Move LibvirtDeployableFinder to libvirt plugin init
@hartmans hartmans merged commit e7c6463 into master Nov 17, 2025
10 of 12 checks passed
@hartmans hartmans deleted the srak/libvirt-plugin branch November 17, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants