Skip to content

Adds implicit behaviors for local directory #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
srak289 wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Adds implicit behaviors for local directory #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd9d5c3
Adds implicit behaviors for local directory
Jun 22, 2025
a584b30
Always check if the current directory is a plugin
Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 31 additions & 15 deletions carthage/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,19 +209,20 @@ def add_carthage_arguments(parser):
parser.add_argument('--config',
metavar="file",
default=[],
help='Specify a user configuration file. If unspecified, Carthage searches for ${PWD}/carthage_config.yml at startup. If this file exists it is read to override other configurations.',
type=argparse.FileType('rt'),
action='append')
parser.add_argument('--command-verbose',
help="Verbose command logging",
action=argparse.BooleanOptionalAction)
parser.add_argument('--tasks-verbose',
help="Verbose logging for tasks",
action=argparse.BooleanOptionalAction)
parser.add_argument('--no-default-config',
dest='default_config',
action='store_false',
default=True,
help='Disable reading /etc/carthage_system.conf as root and ~/.carthage.conf for other users.'
)
parser.add_argument('--plugin',
dest='plugins',
default=[],
action='append',
help='Load a plugin into Carthage',
help='Load a plugin into Carthage. Carthage always searches the current directory for carthage_plugin.yml and carthage_plugin.py. If these files are found, Carthage assumes the current directory is a Carthage plugin, and appends it to the plugin list.',
metavar='plugin')
parser.add_argument('--pull-plugins',
default=None, action='store_true',
Expand All @@ -230,12 +231,12 @@ def add_carthage_arguments(parser):
default=None, dest='pull_plugins',
action='store_false',
help='Do not pull plugins')
parser.add_argument('--no-default-config',
dest='default_config',
action='store_false',
default=True,
help='Disable reading /etc/carthage_system.conf as root and ~/.carthage.conf for other users.'
)
parser.add_argument('--command-verbose',
help="Verbose command logging",
action=argparse.BooleanOptionalAction)
parser.add_argument('--tasks-verbose',
help="Verbose logging for tasks",
action=argparse.BooleanOptionalAction)

return parser

Expand Down Expand Up @@ -279,10 +280,25 @@ def container_debug_filter(record):
logging.getLogger('urllib3.connectionpool').propagate = False
if args.default_config:
load_default_config(config)
if args.pull_plugins is not None:
config.pull_plugins = args.pull_plugins
cwd = Path(os.getcwd())
if args.config == []:
if (cwd/"carthage_config.yml").is_file():
root_logger.info("Found 'carthage_config.yml' in current directory. Continuing with implicit '--config carthage_config.yml'")
args.config.append((cwd/"carthage_config.yml").open("rt"))
for f in args.config:
config.load_yaml(f, ignore_import_errors=ignore_import_errors)
# we need to load our plugin (layout) first to determine if the layout plugin has set pull_plugins=False
if args.pull_plugins is not None:
config.pull_plugins = args.pull_plugins
if (
(cwd/"carthage_plugin.py").is_file()
and (cwd/"carthage_plugin.yml").is_file()
):
root_logger.info("Found Carthage plugin in current directory. Continuing with implicit '--plugin .'")
args.plugins.append(".")
if args.plugins == []:
root_logger.fatal(f"'--plugin' was not specified and current directory does not appear to contain a Carthage plugin. Abort.")
exit(1)
for p in args.plugins:
base_injector(load_plugin, p, ignore_import_errors=ignore_import_errors)
if args.tasks_verbose:
Expand Down
Loading