Merge downstream changes back to master #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* necessary adjustments made for the compliant-framework * Changes kept from upstream * Downstream changes introduced where it made sense
hartmans
added a commit
that referenced
this pull request
Nov 15, 2023
Pick up AwsRouteTablee and AwsInternetGateway from GH-14. * add_route calls resolve_deferred so that your targets and routes can reference injection keys. * Subnet tries to associate with a route table rather than the other way around. I think this means the attachment_id on AwsInternetGateway and the association on AwsRouteTable are not advised and should be rethought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the complete change-set to make the compliant framework function, rebased onto the tip of
master.It is possible that there are inconsistencies to sort out and/or code that needs to be removed.