Skip to content

Fix getGoddardSize so that any arbitrary build folder can be used #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
someone2639 wants to merge 3 commits into
base: develop/2.4.0
Choose a base branch
from
Open

Fix getGoddardSize so that any arbitrary build folder can be used #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2710de2
fix getGoddardSize
Nov 15, 2025
a83aae8
newline
Nov 15, 2025
f0f8b0d
HOW did this get in here
Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ $(BUILD_DIR)/sm64_prelim.elf: $(BUILD_DIR)/sm64_prelim.ld

$(BUILD_DIR)/goddard.txt: $(BUILD_DIR)/sm64_prelim.elf
$(call print,Getting Goddard size...)
$(V)python3 tools/getGoddardSize.py $(BUILD_DIR)/sm64_prelim.map $(VERSION)
$(V)python3 tools/getGoddardSize.py $(BUILD_DIR)/sm64_prelim.map $(BUILD_DIR)

$(BUILD_DIR)/asm/debug/map.o: asm/debug/map.s $(BUILD_DIR)/sm64_prelim.elf
$(call print,Assembling:,$<,$@)
Expand Down
27 changes: 16 additions & 11 deletions tools/getGoddardSize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
import sys, os
import os
import sys

with open(sys.argv[1]) as f:
for line in f:
if "GODDARD_SIZE" in line:
tokens=line.split()
with open("build/%s_n64/goddard.txt" % sys.argv[2], "w+") as f:
sz = int(tokens[0], 16)
sz += 16
sz &= 0xFFFFFFF0
f.write("GODDARD_SIZE = 0x%X;" % sz)

preliminaryMapPath: str = sys.argv[1]
buildFolder: str = sys.argv[2]

with open(preliminaryMapPath) as mapFile:
line: str
for line in mapFile:
if "GODDARD_SIZE" in line:
tokens: list[str] = line.split()
with open(f"{buildFolder}/goddard.txt", "w+") as outputFile:
sz: int = int(tokens[0], 16)
sz += 16
sz &= 0xFFFFFFF0
outputFile.write(f"GODDARD_SIZE = 0x{sz:X};\n")
sys.exit(0)