Release: v2.1.3 #755
Merged
Release: v2.1.3 #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Dockerfile to Ubuntu 22.04 as 18.04 is EOL * Dockerfile: Use modern syntax for mounting * Add gcc-mips-linux-gnu to dockerfile
Co-authored-by: someone2639 <someone2639@gmail.com>
* Fixed one or two bugs, cleaned up a few things, put every non vanilla styled change into POLISHED_TRANSITIONS And renamed set_and_reset_transition_fade_timer * Undid the renaming of set_and_reset_transition_fade_timer as suggested
If a `Go On A Ghost Hunt` Boo is killed while it has a gravity of -1 (at the bottom of its oscillation), and does not hit a wall, it will keep the same negative gravity and continue moving until the textbox is closed. Boo Y speed isn't capped in this scenario, so the constant -1 gravity leads to the boo moving upwards at an increasing rate. This leads to issues in `boo_act_4`. The distance eventually increases to a point where the boo object is too far to be returned in `cur_obj_nearest_object_with_behavior`. This can have 2 buggy effects: - the wrong dialog box being brought up if the textbox is delayed (easiest to do by hanging on a ledge). - the puzzle solved jingle being played incorrectly if you wait in the textbox long enough This doesn't actually cause issues with King Boo, it just brings up the wrong text box. King Boo spawning is unaffected by this bug. The fix is to stop the boo after the death animation has finished playing, stopping the boo from accelerating upwards. I don't believe this to cause any other issues (the boo is already dead after all!) Thanks to Kyman for finding this bug.
* geo layout assert * new idea * Change assert message, add crash screen newline support, and change debug safeguards --------- Co-authored-by: Gregory Heskett <gheskett@gmail.com>
Included in the PR will be a list of comparisons. This does two things: 1. Restores the `dl_ia_text_tex_settings` from the original Super Mario 64. Not sure why this was changed. 2. Changes the S coordinate of two vertices from `vertex_ia8_char` from 480 to 512. This is an error from the original game.
gheskett
added
bug
arthurtilly
approved these changes
Jan 21, 2024
someone2639
approved these changes
Jan 27, 2024
Collaborator
someone2639
left a comment
someone2639
left a comment
There was a problem hiding this comment.
lgtm or whatever they say
* Missed important use of thread6 stack define * Fix build issues with rumble
gheskett
force-pushed
the
develop/2.1.3
branch
from
aeb5fe5 to
9cf3753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.