Add VERTICAL_ROOMS define #430
Conversation
Reonu
added
enhancement
thecozies
left a comment
thecozies
left a comment
There was a problem hiding this comment.
change request for question on possible improvement
| #ifdef ENABLE_VANILLA_LEVEL_SPECIFIC_CHECKS | ||
| if (gCurrLevelNum == LEVEL_BBH) { | ||
| // In BBH, check for a floor manually, since there is an intangible floor. In custom hacks this can be removed. | ||
| #ifdef VERTICAL_ROOMS |
There was a problem hiding this comment.
is there any issue with checking if gCurrentArea->surfaceRooms != NULL instead of using this define? i feel like there has to be a way if checking that an area has rooms before doing this check, that way we dont need to have a define for this and its automatic
There was a problem hiding this comment.
good point, I'll see if that works and if so I'll remove the define
There was a problem hiding this comment.
another consideration we're having: add a flag whether or not an area has surface intangible floors, then if flag then check
|
also bumping this one to get status |
|
I will fix this I promise |
|
He will apparently fix this, he promises. Someone kill him |
|
reonu im going to fucking kill you |
what happened |
|
Reonu. My boy. |
|
ok you know what. you're banished to 3.0 buddy |
|
have fun rebasing IDIOT |
Allows for vertical rooms
VERTICAL ROOMSis enabled,geo_switch_areawill do a manual floor check every frame to check for intangible floors.VERTICAL_ROOMSis disabled:ENABLE_VANILLA_LEVEL_SPECIFIC_CHECKSis enabled, do a manual floor check ONLY in BBH (this vanilla level is the only that uses vertical cloors)ENABLE_VANILLA_LEVEL_SPECIFIC_CHECKSis disabled, never do a manual floor check.