Halyna R. #5
Open
Halyna R. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
hacdias
reviewed
Feb 8, 2026
hacdias
left a comment
hacdias
left a comment
There was a problem hiding this comment.
Hey! In general, very good, and you did all the bonus challenges. So that's quite nice!
I left some minor comments inline. One's a suggestion, one's a question because I think it does affect the output of the question.
finance-tracker/finance.js
Outdated
| let sum = 0; | ||
| for (const transaction of transactions) { | ||
| if (transaction.type === "income") { | ||
| sum = sum + transaction.amount; |
There was a problem hiding this comment.
More of a FYI, this can be simplified to:
Suggested change
| sum = sum + transaction.amount; | |
| sum += transaction.amount; |
| */ | ||
| export function findConsecutiveExpensiveMonths(threshold) { | ||
| const groups = groupTransactionsByMonth(); | ||
| const months = Object.keys(groups).sort(); // chronological order |
There was a problem hiding this comment.
Chronological order? Or alphabetical? 🤔 That'll definitely affect the output.
Author
There was a problem hiding this comment.
Thanks! You’re right — .sort() here sorts the keys alphabetically.
hacdias
added
Reviewed
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete task 4