-
Notifications
You must be signed in to change notification settings - Fork 19
Yusup R. #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Yusup R. #16
Conversation
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
hacdias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Yusuprozimemet
Overall good and I think you meet most of the requirements. I left some minor comments in line. Some things you could've done better according to the assignment guidelines:
- Add comments in some complex logic.
- Format the codebase with Prettier (some places have odd spacings)
- Improved the format output to match with the given example.
Good luck!
| // Place here the transaction data array. Use it in your application as needed. | ||
| const transactions = []; No newline at end of file | ||
| const transactions = [ | ||
| {id: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting seems a bit odd here. Did you run prettier?
| const typeLabel = type === 'income' ? chalk.green('Income') : chalk.red('Expense'); | ||
| const coloredAmount = type === 'income' ? chalk.green(`${amount}`) : chalk.red(`${amount}`); | ||
| const coloredCategory = chalk.yellow(`${category}`); | ||
| console.log(`${index}. [${typeLabel}] ${coloredCategory} - ${coloredAmount} (${description})`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Label type should be fully uppercase and not colored.
No description provided.