-
Notifications
You must be signed in to change notification settings - Fork 19
Hamed R. #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Hamed R. #13
Conversation
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
mo92othman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @HamedRazizadeh-hub, Overall, great work 👏
You implemented all requirements clearly, and your code is easy to follow.
Good job on the extra effort working on the bonus.
| @@ -1,3 +1,83 @@ | |||
| // This is the entrypoint for your application. | |||
| // This is the entrypoint for your application | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line could be deleted.
| getTotalIncome, | ||
| getTotalExpenses, | ||
| getBalance, | ||
| getTransactionsByCategory, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small note 🙂
getTransactionsByCategory is imported here but not used in this file.
It’s best practice to remove unused imports to keep the code clean and easier to read.
| function getLargestExpense() { | ||
| // TODO: Implement this function | ||
| let largest = null; | ||
| for (const transaction of transactions) { | ||
| if ( | ||
| transaction.type === 'expense' && | ||
| (!largest || transaction.amount > largest.amount) | ||
| ) { | ||
| largest = transaction; | ||
| } | ||
| } | ||
| return largest; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice implementation 👍.
No description provided.