MunaNaher_c55-core-week-4 #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
hacdias
reviewed
Feb 8, 2026
Comment on lines
+109
to
+110
| const typeLabel = type === 'income' ? chalk.green('[INCOME]') : chalk.red('[EXPENSE]'); | ||
| console.log(`${id}. ${typeLabel} ${description} - €${amount} (${chalk.yellow(category)})`); |
There was a problem hiding this comment.
I think the amount should've been red/green and not the text "income"/"expense".
hacdias
reviewed
Feb 8, 2026
hacdias
left a comment
hacdias
left a comment
There was a problem hiding this comment.
Hey @MunaNasher!
Good overal. You seem to have completed the whole assignment. Some notes:
- There's some output formatting issues (see inline comment).
- I feel like you didn't run prettier, since there's some odd (too many) spaces and newlines.
- I'd recommend splitting the assignment in multiple files. For example: one with the data, one with the functions, and one with the "app" logic that you'll run.
Nevertheless, it's good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.