Monerh A #18
Open
Monerh A #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelhdr
approved these changes
Jan 30, 2026
rafaelhdr
left a comment
rafaelhdr
left a comment
There was a problem hiding this comment.
The code is working great. Congrats 👏
| else if ((year % 4 === 0 && year % 100 !== 0) || (year % 400 === 0)) { | ||
| console.log(" yes, "+ year + " is a leap year."); | ||
|
|
||
| }else if (year % 4 !== 0 || year % 100 === 0) { // added this to know what considered not a leap year |
There was a problem hiding this comment.
The code is working great and it is approved. But this last if is redundant. You could skip the if.
For example:
if (isLeapYear) {
// do this
} else if (!isLeapYear) {
// do that
}
The conditional is complementary, and it could be just else
if (isLeapYear) {
// do this
} else {
// do that
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.