Minor event selector restyle #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the re-design @crystaltine! A few comments:
|
ganning127
reviewed
Jun 8, 2025
| @@ -0,0 +1,44 @@ | |||
| .registration-bg { | |||
Contributor
There was a problem hiding this comment.
Instead of writing custom CSS, could we use Chakra UI's styling? Try not to introduce custom CSS files unless absolutely necessary. For example, background image/position/size, flex, and positioning can all be done with Chakra UI styling: https://v2.chakra-ui.com/docs/styled-system/style-props#color-and-background-color
ganning127
requested changes
Jun 8, 2025
Contributor
ganning127
left a comment
ganning127
left a comment
There was a problem hiding this comment.
Great start, just left some comments for small changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes the event selector page less empty. its not much better but at least its not a blank white page i guess?
Design is responsive for 500% browser zoom and iphone 12 screen size but the code is VERY SCUFFED (eg. calculating font size using an equation 💀 ) <- this is only a problem for long event names.
Preview