Rsvp reminder cleanup

[michelleyeoh]

No description provided.

[Copilot]

Pull request overview

This PR refactors the RSVP reminder functionality by reorganizing utility files into logical subdirectories and extracting shared functionality into separate modules. The changes improve code organization and maintainability.

Changes:

• Extracted and reorganized utility functions into domain-specific subdirectories (hub/, tito/, mailchimp/)
• Added a new ApplicationCondensed interface for simplified application data used in CSV exports and Mailchimp operations
• Enhanced the useMailchimp hook with a refresh function to allow manual data reloading
• Parameterized getTitoRsvpList to accept an RSVP list index for more flexible RSVP list selection

Reviewed changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
app/_types/application.ts	Added ApplicationCondensed interface for condensed application data
app/(pages)/admin/_hooks/useMailchimp.ts	Refactored hook to expose refresh function using useCallback
app/(pages)/admin/_components/FinalizeButton.tsx	Updated imports and added call to refreshMailchimp after batch processing
app/(pages)/admin/_components/AdminHeader.tsx	Updated import path for prepareMailchimp
app/(api)/_utils/tito/getTitoInvites.ts	Added rsvpListIndex parameter to getTitoRsvpList function
app/(api)/_utils/tito/generateTitoCSV.ts	Updated to use ApplicationCondensed type and adjusted import paths
app/(api)/_utils/mailchimp/prepareMailchimp.ts	Updated import paths to reference reorganized utility files
app/(api)/_utils/mailchimp/mailchimpApiStatus.ts	New file containing Mailchimp API key management logic
app/(api)/_utils/hub/getUnredeemedHubUsers.ts	Updated import paths for reorganized files
app/(api)/_utils/hub/createHubInvite.ts	New file containing Hub invite creation logic (moved from parent directory)
app/(api)/_utils/getFilteredApplications.ts	Updated to use ApplicationCondensed type and adjusted import paths

Comments suppressed due to low confidence (1)

app/(api)/_utils/tito/getTitoInvites.ts:20

• The function should validate that rsvpListIndex is within bounds before accessing the array. If rsvpListIndex is greater than or equal to rsvpLists.length, this will return undefined, which could cause issues in calling code. Consider adding a bounds check and throwing a descriptive error if the index is out of range.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

app/(api)/_utils/tito/getTitoInvites.ts:20

• There's a missing bounds check for the rsvpListIndex parameter. If the index is greater than or equal to the array length, accessing rsvpLists[rsvpListIndex] will return undefined, which could cause issues downstream. Consider adding validation to ensure the index is within bounds before accessing the array.
  app/(api)/_utils/mailchimp/prepareMailchimp.ts:102
• The constant RSVP_LIST_INDEX is duplicated across multiple files (getFilteredApplications.ts and prepareMailchimp.ts). Consider extracting this to a shared configuration file or constant module to maintain consistency and make it easier to update in the future.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

app/(api)/_utils/tito/getTitoInvites.ts:20

• Potential out-of-bounds array access. The function does not validate that rsvpListIndex is within the bounds of the rsvpLists array before accessing it. If rsvpListIndex is greater than or equal to the array length, this will return undefined, which could cause issues in code that expects a valid RSVP list object. Consider adding validation such as checking if rsvpListIndex >= rsvpLists.length or rsvpListIndex < 0 and throwing a descriptive error.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

app/(api)/_utils/tito/getTitoInvites.ts:20

• The function doesn't validate if the rsvpListIndex is within bounds. If the index is out of bounds (e.g., if there's only one RSVP list and index 1 is passed), the function will return undefined, which could cause runtime errors in calling code that expects a valid RSVP list object. Consider adding validation to check if the index is valid before accessing the array.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Missing space in error message. The error message should have a space after the colon for proper formatting.

Suggested change

	alert('Error processing RSVP reminders:' + err.message);
	alert('Error processing RSVP reminders: ' + err.message);

[Copilot]

The popup modal doesn't close when clicking outside of it (on the backdrop). This is a common UX pattern for modal dialogs. Consider adding an onClick handler to the backdrop div that calls setIsPopupOpen(false) to allow users to dismiss the modal by clicking outside.

Suggested change

	<div className="fixed inset-0 bg-black/50 flex items-center justify-center z-50">
	<div className="border-2 border-black bg-white shadow-xl max-w-lg w-full p-6 relative">
	<div
	className="fixed inset-0 bg-black/50 flex items-center justify-center z-50"
	onClick={() => setIsPopupOpen(false)}
	>
	<div
	className="border-2 border-black bg-white shadow-xl max-w-lg w-full p-6 relative"
	onClick={(e) => e.stopPropagation()}
	>